Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Blob throughput increase #8452

Merged
merged 16 commits into from
Sep 17, 2024

Conversation

parithosh
Copy link
Member

@parithosh parithosh commented Apr 17, 2024

No description provided.

@parithosh parithosh requested a review from eth-bot as a code owner April 17, 2024 21:14
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Apr 17, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 17, 2024

✅ All reviewers have approved.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 17, 2024
@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Apr 17, 2024
@eth-bot eth-bot changed the title Adding blob target increase EIP Add EIP: Blob throughput increase Apr 17, 2024
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Apr 17, 2024
Copy link

The commit 4fc90be (as a parent of 222a277) contains errors.
Please inspect the Run Summary for details.

EIPS/eip-xxxx.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Apr 17, 2024
EIPS/eip-7691.md Outdated Show resolved Hide resolved
EIPS/eip-7691.md Outdated Show resolved Hide resolved
EIPS/eip-7691.md Outdated Show resolved Hide resolved
parithosh and others added 3 commits April 18, 2024 17:20
@parithosh parithosh changed the title Add EIP: Blob throughput increase EIP 7691: Blob throughput increase Apr 25, 2024
EIPS/eip-7691.md Outdated

Ethereum, with its rollup centric roadmap, scales by relying on L2. Since the Dencun fork, the blob gas target and maximum was set to 3/6 respectively. The blob gas limit was arrived at based on a series of big block tests performed on the Ethereum mainnet network as well as a series of testnets. The values were chosen cautiously, as its extremely hard to predict the exact p2p behaviour of Ethereum mainnet.

As we now have the Dencun upgrade live, we are able to use monitoring tools to check the network health. Initial monitoring indicates that we have a stable network with the current gas target, allowing us to consider starting a series of big block and blob tests to determine the theoretical headroom we currently have. The EIP would then be updated to include a proposed new blob gas target and limit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add more details of the monitoring results or link to somewhere where it is documented? That would give the reader a clear picture of how much the network health has been affected and the fact that it is in an acceptable range.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we will have multiple writeups published. We're currently working on some tools to get us more low level p2p visibility, once that's considered stable-ish we will trigger a new round of big block tests on Mainnet to gather the data.

@eth-bot eth-bot changed the title EIP 7691: Blob throughput increase Add EIP: Blob throughput increase May 8, 2024
EIPS/eip-7691.md Outdated Show resolved Hide resolved
EIPS/eip-7691.md Outdated

Ethereum, with its rollup centric roadmap, scales by relying on L2. Since the Dencun fork, the blob gas target and maximum was set to 3/6 respectively. The blob gas limit was arrived at based on a series of big block tests performed on the Ethereum mainnet network as well as a series of testnets. The values were chosen cautiously, as its extremely hard to predict the exact p2p behaviour of Ethereum mainnet.

As we now have the Dencun upgrade live, we are able to use monitoring tools to check the network health. Initial monitoring indicates that we have a stable network with the current gas target, allowing us to consider starting a series of big block and blob tests to determine the theoretical headroom we currently have. The EIP would then be updated to include a proposed new blob gas target and limit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposals should be written as if they are already Final. It's just too easy to miss these kind of sentences while reviewing, and it looks really weird when a Final EIP has something like "The EIP would then be updated..."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, i've changed the language to indicate this

EIPS/eip-7691.md Outdated

Additional EIPs such as [EIP-7623](./eip-7623.md) proposes a calldata cost increase which would significantly lower the worst case base block size, thus creating more headroom for a potential blob throughput increase.

The current long term plan of Ethereum is to implement peerDAS, but given the uncertain timelines, this EIP aims to increase the throughput short term to provide some scaling until future solutions are deployed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[...] implement peerDAS [...]

Can you quickly elaborate on what peerDAS is for the unfamiliar, or link to an EIP defining it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a link to the EIP

EIPS/eip-7691.md Outdated Show resolved Hide resolved
EIPS/eip-7691.md Outdated Show resolved Hide resolved
EIPS/eip-7691.md Outdated Show resolved Hide resolved
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jul 29, 2024
@eth-bot eth-bot enabled auto-merge (squash) September 17, 2024 14:30
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eth-bot eth-bot merged commit 78ae640 into ethereum:master Sep 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants